Skip to content

Mute flaky concurrent segment search tests pending fixes#10437

Merged
sohami merged 1 commit intoopensearch-project:mainfrom
jed326:mute_tests
Oct 6, 2023
Merged

Mute flaky concurrent segment search tests pending fixes#10437
sohami merged 1 commit intoopensearch-project:mainfrom
jed326:mute_tests

Conversation

@jed326
Copy link
Copy Markdown
Contributor

@jed326 jed326 commented Oct 6, 2023 •
edited
Loading

Muted tests:

  • DiversifiedSamplerIT.testNestedSamples
  • QueryProfilePhaseTests.testMaxScore
  • QueryProfilePhaseTests.testCollapseQuerySearchResults
  • HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
  • FieldCapabilitiesIT.testWithIndexFilter
  • QueryProfilePhaseTests.testDisableTopScoreCollection

Description

Muting these tests only for concurrent search enabled cases.
See:

Haven't seen any reported failures for #9401 or #9464 for a while now so leaving those unmuted.

#10154 is not specifically flaky for concurrent search.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jed326
Copy link
Copy Markdown
Contributor Author

jed326 commented Oct 6, 2023

@sohami @andrross could you help review? Thanks!

@jed326 jed326 marked this pull request as ready for review October 6, 2023 01:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 6, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 5538b90

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@jed326
Copy link
Copy Markdown
Contributor Author

jed326 commented Oct 6, 2023 •
edited
Loading

I also spent some time trying to reproduce #9464 without much success 😕

@jed326
Mute flaky concurrent segment search tests pending fixes
5538b90 
* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: Jay Deng <dengjay@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

@jed326
Copy link
Copy Markdown
Contributor Author

jed326 commented Oct 6, 2023

https://build.ci.opensearch.org/job/gradle-check/27343/

#7530

@sohami
Copy link
Copy Markdown
Contributor

sohami commented Oct 6, 2023

Merging this PR since it is just muting existing flaky tests and the failure is unrelated to this PR

@sohami sohami added the backport 2.x Backport to 2.x branch label Oct 6, 2023
@sohami sohami merged commit 9cb4f9d into opensearch-project:main Oct 6, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2023
@github-actions
Mute flaky concurrent segment search tests pending fixes (#10437)
1a03233 
* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: Jay Deng <dengjay@amazon.com>
(cherry picked from commit 9cb4f9d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 6, 2023
Closed
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 9, 2023
@jed326 @deshsidd
Mute flaky concurrent segment search tests pending fixes (opensearch-…
1f0301e 
…project#10437)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: Jay Deng <dengjay@amazon.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
@jed326 @austin-aryn-ai
Mute flaky concurrent segment search tests pending fixes (opensearch-…
7e0e6e1 
…project#10437)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: Jay Deng <dengjay@amazon.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
@jed326 @austin-aryn-ai
Mute flaky concurrent segment search tests pending fixes (opensearch-…
32fed14 
…project#10437)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: Jay Deng <dengjay@amazon.com>
@jed326 jed326 mentioned this pull request Oct 30, 2023
Closed
jed326 added a commit to jed326/OpenSearch that referenced this pull request Nov 1, 2023
@jed326
Mute flaky concurrent segment search tests pending fixes (opensearch-…
8ac49fa 
…project#10437)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: Jay Deng <dengjay@amazon.com>
@jed326 jed326 mentioned this pull request Nov 1, 2023
Merged
8 tasks
jed326 added a commit to jed326/OpenSearch that referenced this pull request Nov 1, 2023
@jed326
Mute flaky concurrent segment search tests pending fixes (opensearch-…
c6bd9bf 
…project#10437)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: Jay Deng <dengjay@amazon.com>
jed326 added a commit to jed326/OpenSearch that referenced this pull request Nov 2, 2023
@jed326
Mute flaky concurrent segment search tests pending fixes (opensearch-…
0bea75c 
…project#10437)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
jed326 added a commit to jed326/OpenSearch that referenced this pull request Nov 2, 2023
@jed326
Mute flaky concurrent segment search tests pending fixes (opensearch-…
bff20e0 
…project#10437)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
jed326 added a commit to jed326/OpenSearch that referenced this pull request Nov 2, 2023
@jed326
Mute flaky concurrent segment search tests pending fixes (opensearch-…
de72d2d 
…project#10437)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
jed326 added a commit to jed326/OpenSearch that referenced this pull request Nov 3, 2023
@jed326
Mute flaky concurrent segment search tests pending fixes (opensearch-…
66260ae 
…project#10437)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
peternied pushed a commit that referenced this pull request Nov 6, 2023
@jed326
Mute flaky concurrent segment search tests pending fixes (#10437) (#1…
74d1bb1 
…1050)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
@jed326 jed326 mentioned this pull request Nov 6, 2023
Merged
8 tasks
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Dec 13, 2023
@jed326 @austin-aryn-ai
Mute flaky concurrent segment search tests pending fixes (opensearch-…
c8cb7a0 
…project#10437)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: Jay Deng <dengjay@amazon.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Jan 19, 2024
@jed326 @austin-aryn-ai
Mute flaky concurrent segment search tests pending fixes (opensearch-…
245c056 
…project#10437)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: Jay Deng <dengjay@amazon.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Jan 19, 2024
@jed326 @austin-aryn-ai
Mute flaky concurrent segment search tests pending fixes (opensearch-…
8c2c617 
…project#10437)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: Jay Deng <dengjay@amazon.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Feb 6, 2024
@jed326 @austin-aryn-ai
Mute flaky concurrent segment search tests pending fixes (opensearch-…
81e7537 
…project#10437)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: Jay Deng <dengjay@amazon.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Feb 6, 2024
@jed326 @austin-aryn-ai
Mute flaky concurrent segment search tests pending fixes (opensearch-…
db91c1f 
…project#10437)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: Jay Deng <dengjay@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@jed326 @shiv0408
Mute flaky concurrent segment search tests pending fixes (opensearch-…
c284cfa 
…project#10437)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: Jay Deng <dengjay@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
@jed326 jed326 deleted the mute_tests branch August 7, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrross andrross andrross approved these changes

@sohami sohami sohami approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees

No one assigned

Labels

backport 2.x Backport to 2.x branch skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jed326 @sohami @reta @andrross